[Gossip-dev] [Telepathy] rework of the UI

[Xavier Claessens]

Le mercredi 13 septembre 2006 à 11:58 -0700, Eitan Isaacson a écrit :
> On Wed, 2006-09-13 at 17:13 +0200, Richard Hult wrote:
> > Hi,
> > 
> > I just took a very quick look at the patch:
> > 
> > * Please try to avoid whitespace-only changes
> > 
> > * Use g_object_set() instead of setting up a gvalue and using
> > g_object_set_property (and when using g_object_set, don't cast the object).
> > 
> > * g_value_transform looks suspicious, is that right? don't you just want
> > to copy the value?
> > 
> > * What's the reason for having the function that returns a hash table
> > with all params?
> 
> I just had an idea: instead of returning a hashtable, we could have a
> function called gossip_account_params_foreach() - One more step in
> hiding the implementation without having to iterate over all the
> parameters a million times.

Seems good to me. I'll try to implement that.

Xavier.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url : http://lists.imendio.com/pipermail/gossip-dev/attachments/20060913/25fab748/attachment-0001.pgp