[Gossip-dev] final account rework

[Xavier Claessens]

Le vendredi 06 octobre 2006 à 22:45 +0200, Richard Hult a écrit :
> Xavier Claessens skrev:
> 
> > The patch
> > http://users.skynet.be/Zdra/gossip-account.patch
> 
> This patch looks OK to me in general. I assume that you have tested it
> so that it works and so on :)

It works for me. I would be happy if others can test it too :-)

> I would call the new_account function create_account.

Ok.

> > New files in src/
> > http://users.skynet.be/Zdra/gossip-account-jabber.c
> > http://users.skynet.be/Zdra/gossip-account-jabber.h
> > http://users.skynet.be/Zdra/gossip-account-unknown.c
> > http://users.skynet.be/Zdra/gossip-account-unknown.h
> 
> Should the latter be called -generic? Unknown sounds a bit odd to me.
> I'd also prefer to have some kind of indication that we are talking
> about a dialog/window here, gossip-account-dialog-jabber for example.

Ok I can rename to gossip-account-generic. It's not a window nor a
dialog, it's a widget... So what about gossip-account-jabber-widget ?

Xavier.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url : http://lists.imendio.com/pipermail/gossip-dev/attachments/20061006/fd2d50e0/attachment.pgp