***SPAM*** Re: [Gossip-dev] Bug #368794

[Martyn Russell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Xavier Claessens wrote:
> Hi,

Hi,

> I'm trying to fix bug #368794 [1]. The problem seems to be in
> gossip_session_find_account_for_own_contact() which compares accounts ID
> to know if 2 accounts are the same.
> 
> I'm connecting both MSN and jabber accounrs using the same ID
> ("xclaesse at gmail.com") using telepathy and so gossip gets confused and
> doesn't return the good account.
> 
> The problem is also in gossip_contact_equal() because it compares with
> ID to tell if 2 accounts are the same.
> 
> Why not simply compare pointers ?

No definitely not. What if the GossipContact is not the same pointer but
it is the same contact ultimately.

> GossipAccount *a1;
> GossipAccount *a2;
> (...)
> if (a1 == a2) {...}

What should happen is the contact ID and the account ID should be
compared, this is the only way I see of making sure the contact is the
right one.

> I guess it's to only show one contact if I connect more than one account
> that have same contacts in their list ? Using telepathy this isn't a
> good solution because I can have the same ID for one contact but using
> different protocols ! If I add "someone at gmail.com" in my MSN and jabber
> list I want to see both and choose myself which protocol I want to use
> to talk with him.

Yes, this is quite tricky. I have put some thought into it, but haven't
really come up with a solution to fix it.

> To solve the duplicate of contacts Gaim groups them, it's by far more
> flexible but maybe more difficult to implement... Should be great to
> make something like gaim does...

No, I don't like the way GAIM does it.

> [1] http://bugzilla.gnome.org/show_bug.cgi?id=368794

There is a patch attached to this bug:
http://bugzilla.gnome.org/show_bug.cgi?id=322110

I tried it and didn't think it was adequate enough.

- --
Regards,
Martyn
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFVhWfwpLEnE7M298RAnaMAJ4uLGMJQh8x7kvEsxQsQlk/z0+ksQCfenzW
9GQ9XtHgOINEbjlY6odXC2Q=
=7iCg
-----END PGP SIGNATURE-----