[Gossip-dev] Bug #368794

[Xavier Claessens]

Le samedi 11 novembre 2006 à 12:08 +0100, Aurelien Naldi a écrit :
> Le samedi 11 novembre 2006 à 11:26 +0100, Xavier Claessens a écrit :
> > Hi,
> > 
> > I'm trying to fix bug #368794 [1]. The problem seems to be in
> > gossip_session_find_account_for_own_contact() which compares accounts ID
> > to know if 2 accounts are the same.
> > 
> > I'm connecting both MSN and jabber accounrs using the same ID
> > ("xclaesse at gmail.com") using telepathy and so gossip gets confused and
> > doesn't return the good account.
> > 
> > The problem is also in gossip_contact_equal() because it compares with
> > ID to tell if 2 accounts are the same.
> > 
> > Why not simply compare pointers ?
> > 
> > GossipAccount *a1;
> > GossipAccount *a2;
> > (...)
> > if (a1 == a2) {...}
> > 
> > I guess it's to only show one contact if I connect more than one account
> > that have same contacts in their list ? Using telepathy this isn't a
> > good solution because I can have the same ID for one contact but using
> > different protocols ! If I add "someone at gmail.com" in my MSN and jabber
> > list I want to see both and choose myself which protocol I want to use
> > to talk with him.
> > 
> > To solve the duplicate of contacts Gaim groups them, it's by far more
> > flexible but maybe more difficult to implement... Should be great to
> > make something like gaim does...
> > 
> > Comments are welcome,
> > Xavier Claessens.
> 
> This reminds me of an other bug I reported and tryed to fix a while ago,
> I think it has been closed since (and I do not have a pointer here) but
> after testing it is still here: if two gossip account have the same
> contact, gossip can not distinguish them.
> 
> * open gossip and connect account A and B, both of them have C as
> contact.
> * C talks to A, gossip correctly responds using account A
> * C talks to B, gossip put everything in the same chat window and
> answers using account A again.
> 
> while this could be a nice feature, it is annoying in some cases,
> especially as there is no way to tell gossip which account should be
> used first.
> 
> I would really love to see these things fixed, contact grouping seems to
> be the right way, but I cannot help, except by testing as I do not have
> much hacking time :/

I think it's related to my bug. I'll try to remove all id comparison and
use pointer comparison instead, if there is no objection (martyn, your
opinion ?)

> On a related note, some kind of evolution integration would also be
> nice, evolution already allows several IM adress per contact.

The problem with integration between IM programs is every IM client has
a different DBus interface. Evolution shouldn't use gossip and gossip
shouln't support evolution, both should talk to telepathy and MC (at
least that's what I understood).

Xavier.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Ceci est une partie de message
	=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
Url : http://lists.imendio.com/pipermail/gossip-dev/attachments/20061111/8b7f45ce/attachment.pgp