[Gossip-dev] Remove some functions from GossipProtocol that can't be implemented in TELEPATHY

[Martyn Russell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Xavier Claessens wrote:
> * _get_default_server is used to extract the server from an ID and take
> care of special cases: user at gmail.com has talk.google.com server, this
> kind of conversion can't be done in the telepathy protocol since this is
> a generic protocol for more than one real protocol. GossipTelepathy is
> used for either msn, jabber, etc. The only place we have real protocol
> depend code is in the UI (gossip-account-widget-*.c). I think the
> gmail.com -> talk.google.com conversion is only useful in the jabber
> settings widget. This conversion is something needed in gossip-tp and
> the only way is to put it in the UI, or someone has suggestions ?

I have not looked in detail how this works, but I would assume that all
you need to do is store a list of GossipProtocols against some telepathy
thing which you use (a connection?) and that type of connection (Jabber,
MSN, etc) should be known in the backend surely? Otherwise how to do
create the different types of GossipAccounts? If this is known, then I
don't see why you can't do specific things in the telepathy backend
based on that information per protocol?

It, too me, just sounds like a little bit of work, maybe I am wrong?

If this is not at all possible for some protocols, you can just return
NULL here, it doesn't have to be supported for all protocols because it
may not be pertinent for them all. That was my point with my comments on
the bug, we are likely to have unique features of protocols added here I
would imagine and only some protocols will support those features. The
point about GossipProtocol is it is an interface so it can be partially
or fully implemented.

> * _get_default_port is also something users really need. It returns the
> port depending on SSL. I think we only need that for the jabber settings
> widget and it depends on the protocol. It can't be done in the telepathy
> protocol (AFAIK) because the telepathy protocol doesn't know if it's a
> jabber or msn or whatever the real protocol is.

I would have thought this would be something quite fundamental for some
unique aspects of the backend. Such as these functions.

> I really want to fix those 2 points, for others it's not very important.
> 
> For get_example_* maybe it make sense to have something in the telepathy
> spec to get an example for each parameter.

Yes, think we have discussed this before and as I recall the response
was divided. I would like to see the backend tell me the UI what example
to use and make the UI as unaware of protocols as possible, but I think
Micke and Robert thought it should be done by the UI.

All in all, I am not strongly worried about having UI protocol specific
code, because for somethings at some point we will need to anyway, I am
just interested in keeping it to a minimum.

- --
Regards,
Martyn
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFkQdEwpLEnE7M298RAkpiAKCGxTee1hJt2wP35REmsvFNxdPO5QCfSBXc
JJwVcTaoDzfazB/1c9Y1KWo=
=mJOm
-----END PGP SIGNATURE-----