[Gossip-dev] [PATCH] GossipContact should emit himself property notifications and updated signal

[Mikael Hallendal]

10 dec 2006 kl. 00.22 skrev Xavier Claessens:

Hi,

> On sam, 2006-12-09 at 13:26 +0100, Xavier Claessens wrote:
>> Hi,
>>
>> I made a big patch [1]. Comments are welcomed. I think it needs  
>> testing
>> to be sure to not have regressions, it's why I post on the ML.
>>
>> So please test the patch and tell me if contact's information are  
>> always
>> updated everywhere on the UI.
>>
>> Thanks.
>>
>> Xavier Claessens.
>>
>
> Same kind of thing: Why is signal "chatroom-contact-joined" emitted on
> the GossipProtocol ? Shouldn't it be emitted on the chatroom itself ?
>
> If there is a special reason please tell me :-)

The main reason for this is that GossipContact is a passive data  
object and it doesn't really get updated (on the server) before you  
call gossip_session_update_contact ().

The other reason is to not have to connect to every contact in all  
places where you are interested, the current way you only have to  
connect to one signal contact-updated (for example).

I think changing this so that you have signals on GossipContact will  
lead to some confusion regarding when it is emitted as I would expect  
it to be emitted as soon as I change it locally (before calling  
gossip_session_update_contact()).

Cheers,
   Mikael Hallendal

--
Imendio AB, http://www.imendio.com