[Gossip-dev] Accelerator key inconsistencies

CJ van den Berg cj at vdbonline.com
Tue Aug 8 21:24:33 CEST 2006


On Tue, Aug 08, 2006 at 05:02:23PM +0100, Martyn Russell wrote:
> > I just noticed too, that "hide contact list" (or whatever it used to be
> > called) has disappeared from the menu in 0.14.
> 
> I guess it is because of:
> 
> 	if (!gossip_have_tray ()) {
> 		hidden = FALSE;
> 		gtk_widget_hide (GTK_WIDGET (priv->actions_hide_list));
> 
> It was broken, the else statement didn't call gtk_widget_show() so I
> guess it was hidden in the glade file?
> 
> Anyway, thanks, I have committed a fix.

I think it's because gossip usually loads faster that the tray on my
machine, so at the time of the gossip_have_tray() call there is indeed no
tray so the menu item gets hidden. If I re-load gossip later after the panel
has loaded and is running, then the menu item is there. I guess gossip must
have some code to detect the late arrival of the tray because the tray icon
showes up fine when the panel is finally finished loading. Maybe the code
that does that should un-hide the menu item again too?

-- 
CJ van den Berg

mailto:cj at vdbonline.com
  xmpp:cj at vdbonline.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.imendio.com/pipermail/gossip-dev/attachments/20060808/8f8aacd5/attachment-0001.pgp


More information about the Gossip-dev mailing list